PMD Results

The following document contains the results of PMD 4.2.2.

Files

net/sf/bacchus/AbstractContainer.java

Violation Line
This class has too many methods, consider refactoring it. 13 - 251
Avoid variables with short names like o 150
Avoid variables with short names like o 158
An empty method in an abstract class should be abstract instead 247 - 249

net/sf/bacchus/AbstractControl.java

Violation Line
The class 'AbstractControl' has a Cyclomatic Complexity of 4 (Highest = 14). 6 - 194
The method 'validate' has a Cyclomatic Complexity of 14. 121 - 154

net/sf/bacchus/AbstractRecord.java

Violation Line
Avoid excessively long variable names like RECORD_TYPE_FORMAT 11
String.trim().length()==0 is an inefficient way to validate an empty String. 29
String.trim().length()==0 is an inefficient way to validate an empty String. 80

net/sf/bacchus/CompanyBatch.java

Violation Line
Avoid excessively long variable names like MIXED_DEBITS_CREDITS 11
Avoid excessively long variable names like AUTOMATED_ACCOUNTING_ADVICES 20
A switch with less than 3 branches is inefficient, use a if statement instead. 109 - 115
A switch with less than 3 branches is inefficient, use a if statement instead. 128 - 134

net/sf/bacchus/CompanyBatchControl.java

Violation Line
The class 'CompanyBatchControl' has a Cyclomatic Complexity of 2 (Highest = 12). 7 - 266
Avoid excessively long variable names like messageAuthenticationCode 32
Avoid excessively long variable names like messageAuthenticationCode 124
Avoid if (x != y) ..; else ..; 198 - 202
The method normalize() has an NPath complexity of 240 221 - 249
The method 'normalize' has a Cyclomatic Complexity of 12. 221 - 249

net/sf/bacchus/CompanyBatchHeader.java

Violation Line
Avoid excessively long variable names like standardEntryClass 47
Avoid excessively long variable names like standardEntryClass 170
The method normalize() has an NPath complexity of 256 372 - 408
Overriding method merely calls super 418 - 423

net/sf/bacchus/Control.java

Violation Line
Avoid excessively long variable names like FILE_CONTROL_RECORD 9
Avoid excessively long variable names like BATCH_CONTROL_RECORD 12

net/sf/bacchus/FileHeader.java

Violation Line
Avoid excessively long variable names like DEFAULT_BLOCK_SIZE 13
Overriding method merely calls super 366 - 371

net/sf/bacchus/Header.java

Violation Line
Avoid excessively long variable names like FILE_HEADER_RECORD 7
Avoid excessively long variable names like BATCH_HEADER_RECORD 10

net/sf/bacchus/Record.java

Violation Line
Non-static initializers are confusing 17 - 21

net/sf/bacchus/charset/X_ACH_XL.java

Violation Line
The class 'Transliterator' has a Cyclomatic Complexity of 6 (Highest = 16). 33 - 160
Avoid variables with short names like cs 42
Avoid variables with short names like cs 52
Avoid variables with short names like c 74
Avoid variables with short names like c 102
The method 'mapToString' has a Cyclomatic Complexity of 16. 102 - 159
Avoid variables with short names like cs 175

net/sf/bacchus/charset/X_ACH_XP.java

Violation Line
Avoid excessively long variable names like LATIN_1_SUPPLEMENT 29
Avoid variables with short names like cs 62
Avoid variables with short names like cs 72
Avoid variables with short names like c 83
Avoid variables with short names like cs 125

net/sf/bacchus/charset/X_US_ASCII_ACH.java

Violation Line
Avoid variables with short names like cs 43
Avoid variables with short names like in 55
Avoid variables with short names like b 58
Avoid variables with short names like cs 85
Avoid variables with short names like cs 95
Avoid variables with short names like in 106
Avoid variables with short names like c 114
Avoid variables with short names like c 144
Avoid variables with short names like cs 170

net/sf/bacchus/records/AbstractAddenda.java

Violation Line
Avoid excessively long variable names like ADDENDA_TYPE_FORMAT 14
Avoid excessively long variable names like entryDetailSequence 20
Avoid excessively long variable names like entryDetailSequence 77
Overriding method merely calls super 166 - 168

net/sf/bacchus/records/AbstractDetail.java

Violation Line
The class 'AbstractDetail' has a Cyclomatic Complexity of 2 (Highest = 14). 18 - 468
Avoid excessively long variable names like MAX_TRANSACTION_TYPE 21
It is somewhat confusing to have a field name with the same name as a method 39 - 40
The method validate() has an NPath complexity of 576 321 - 370
The method 'validate' has a Cyclomatic Complexity of 14. 321 - 370
The method normalize() has an NPath complexity of 3168 392 - 430
The method 'normalize' has a Cyclomatic Complexity of 13. 392 - 430
An empty method in an abstract class should be abstract instead 465 - 467

net/sf/bacchus/records/AbstractTerminalDetail.java

Violation Line
Overriding method merely calls super 159 - 162

net/sf/bacchus/records/Check.java

Violation Line
Overriding method merely calls super 87 - 89

net/sf/bacchus/records/DestroyedCheck.java

Violation Line
Avoid excessively long variable names like itemResearchNumber 67
Overriding method merely calls super 113 - 116

net/sf/bacchus/records/Info.java

Violation Line
Avoid excessively long variable names like paymentRelatedInfo 20
Avoid excessively long variable names like paymentRelatedInfo 54
Overriding method merely calls super 89 - 93

net/sf/bacchus/records/Payment.java

Violation Line
Overriding method merely calls super 88 - 90

net/sf/bacchus/records/PointOfPurchase.java

Violation Line
Overriding method merely calls super 87 - 89

net/sf/bacchus/records/Terminal.java

Violation Line
Avoid excessively long variable names like transactionSerialNumber 31
Avoid excessively long variable names like terminalIdentification 34
Avoid excessively long variable names like transactionSerialNumber 92
Avoid excessively long variable names like terminalIdentification 108
Overriding method merely calls super 288 - 293

net/sf/bacchus/spring/RecordProcessLogger.java

Violation Line
Avoid variables with short names like e 39

net/sf/bacchus/spring/RecordProcessorSupport.java

Violation Line
Too many static imports may lead to messy code 1 - 236
This class has too many methods, consider refactoring it. 29 - 236
The class 'RecordProcessorSupport' has a Cyclomatic Complexity of 2 (Highest = 11). 29 - 236
The method 'process' has a Cyclomatic Complexity of 11. 74 - 115
Avoid throwing null pointer exceptions. 80

net/sf/bacchus/spring/RecordSpecializer.java

Violation Line
The class 'RecordSpecializer' has a Cyclomatic Complexity of 3 (Highest = 11). 28 - 261
Avoid catching NullPointerException; consider removing the cause of the NPE. 126
The method 'processDetail' has a Cyclomatic Complexity of 11. 140 - 186