The following document contains the results of Checkstyle
.
| Files | Infos |
Warnings |
Errors |
|---|---|---|---|
| 51 | 0 | 0 | 341 |
| Rules | Violations | Severity |
|---|---|---|
| PackageHtml | 0 | |
| JavadocType | 1 | |
| JavadocMethod | 8 | |
| JavadocVariable | 1 | |
| JavadocStyle | 0 | |
| AbstractClassName | 0 | |
| ConstantName | 0 | |
| LocalFinalVariableName | 0 | |
| LocalVariableName | 0 | |
| MemberName | 0 | |
| MethodName | 0 | |
| PackageName | 0 | |
| ParameterName | 0 | |
| StaticVariableName | 0 | |
| TypeName | 3 | |
| AvoidStarImport | 0 | |
| IllegalImport | 0 | |
| UnusedImports | 1 | |
ImportOrder
|
11 | |
| ExecutableStatementCount | 0 | |
| FileLength | 0 | |
LineLength
|
2 | |
| MethodLength | 0 | |
| AnonInnerLength | 1 | |
| ParameterNumber | 0 | |
| EmptyForInitializerPad | 0 | |
| EmptyForIteratorPad | 0 | |
| MethodParamPad | 0 | |
NoWhitespaceAfter
|
0 | |
| NoWhitespaceBefore | 0 | |
| OperatorWrap | 0 | |
| ParenPad | 0 | |
| TypecastParenPad | 0 | |
| TabCharacter | 0 | |
| WhitespaceAfter | 0 | |
WhitespaceAround
|
0 | |
| ModifierOrder | 0 | |
| RedundantModifier | 0 | |
| EmptyBlock | 0 | |
| LeftCurly | 0 | |
| NeedBraces | 0 | |
RightCurly
|
79 | |
RightCurly
|
79 | |
| AvoidNestedBlocks | 0 | |
| ArrayTrailingComma | 2 | |
| CovariantEquals | 0 | |
| DoubleCheckedLocking | 0 | |
| EmptyStatement | 0 | |
| EqualsHashCode | 0 | |
FinalLocalVariable
|
0 | |
HiddenField
|
1 | |
IllegalInstantiation
|
1 | |
IllegalToken
|
0 | |
| InnerAssignment | 0 | |
| MagicNumber | 152 | |
| MissingSwitchDefault | 0 | |
| ModifiedControlVariable | 0 | |
RedundantThrows
|
0 | |
| SimplifyBooleanExpression | 0 | |
| SimplifyBooleanReturn | 0 | |
| StringLiteralEquality | 0 | |
| NestedIfDepth | 0 | |
| NestedTryDepth | 0 | |
| SuperClone | 0 | |
| SuperFinalize | 0 | |
| IllegalCatch | 0 | |
| IllegalThrows | 0 | |
| PackageDeclaration | 0 | |
| JUnitTestCase | 0 | |
ReturnCount
|
4 | |
| IllegalType | 0 | |
| DeclarationOrder | 4 | |
| ParameterAssignment | 0 | |
| ExplicitInitialization | 1 | |
| DefaultComesLast | 0 | |
| MissingCtor | 19 | |
| FallThrough | 0 | |
| MultipleStringLiterals | 16 | |
| MultipleVariableDeclarations | 0 | |
| UnnecessaryParentheses | 0 | |
| VisibilityModifier | 0 | |
| FinalClass | 0 | |
| InterfaceIsType | 0 | |
| HideUtilityClassConstructor | 0 | |
| MutableException | 0 | |
ThrowsCount
|
0 | |
BooleanExpressionComplexity
|
1 | |
ClassDataAbstractionCoupling
|
1 | |
ClassFanOutComplexity
|
0 | |
CyclomaticComplexity
|
8 | |
NPathComplexity
|
9 | |
JavaNCSS
|
1 | |
| UncommentedMain | 0 | |
| UpperEll | 0 | |
| ArrayTypeStyle | 0 | |
FinalParameters
|
0 | |
Indentation
|
14 | |
| TrailingComment | 0 | |
NewlineAtEndOfFile
|
0 | |
| Translation | 0 |
| Violation | Message | Line |
|---|---|---|
| '}' should be alone on a line. | 40 | |
| '}' should be alone on a line. | 44 | |
| Cyclomatic Complexity is 11 (max allowed is 10). | 64 | |
| '}' should be alone on a line. | 68 | |
| '}' should be alone on a line. | 70 | |
| '}' should be alone on a line. | 77 | |
| '}' should be alone on a line. | 80 | |
| '}' should be alone on a line. | 82 | |
| '}' should be alone on a line. | 84 | |
| '}' should be alone on a line. | 100 | |
| '}' should be alone on a line. | 104 | |
| '}' should be alone on a line. | 106 |
| Violation | Message | Line |
|---|---|---|
| '}' should be alone on a line. | 51 | |
| '}' should be alone on a line. | 71 | |
| '}' should be alone on a line. | 91 | |
| '}' should be alone on a line. | 111 | |
| Cyclomatic Complexity is 14 (max allowed is 10). | 120 | |
| NPath Complexity is 32 (max allowed is 20). | 120 | |
| '}' should be alone on a line. | 137 |
| Violation | Message | Line |
|---|---|---|
| Missing a Javadoc comment. | 8 | |
| '}' should be alone on a line. | 54 | |
| method def throws at indentation level 12 not at correct indentation, 8 | 72 | |
| The String "Missing value for " appears 2 times in the file. | 75 | |
| '}' should be alone on a line. | 77 | |
| The String "greater than " appears 2 times in the file. | 78 | |
| '}' should be alone on a line. | 80 | |
| '}' should be alone on a line. | 104 | |
| The String "negative" appears 2 times in the file. | 107 | |
| Line is longer than 120 characters. | 115 | |
| The String "record type" appears 2 times in the file. | 136 | |
| '}' should be alone on a line. | 137 | |
| '9' is a magic number. | 137 | |
| '}' should be alone on a line. | 139 |
| Violation | Message | Line |
|---|---|---|
| Class should define a constructor. | 8 | |
| '}' should be alone on a line. | 47 | |
| NPath Complexity is 32 (max allowed is 20). | 155 |
| Violation | Message | Line |
|---|---|---|
| The String "%012d" appears 2 times in the file. | 16 | |
| '}' should be alone on a line. | 75 | |
| '}' should be alone on a line. | 87 | |
| '}' should be alone on a line. | 99 | |
| '}' should be alone on a line. | 135 | |
| '}' should be alone on a line. | 158 | |
| '4' is a magic number. | 178 | |
| '4' is a magic number. | 179 | |
| '10' is a magic number. | 179 | |
| '10' is a magic number. | 180 | |
| '20' is a magic number. | 180 | |
| '20' is a magic number. | 181 | |
| '32' is a magic number. | 181 | |
| '32' is a magic number. | 182 | |
| '44' is a magic number. | 182 | |
| '44' is a magic number. | 183 | |
| '54' is a magic number. | 183 | |
| '54' is a magic number. | 184 | |
| '73' is a magic number. | 184 | |
| '79' is a magic number. | 185 | |
| '87' is a magic number. | 185 | |
| '87' is a magic number. | 186 | |
| '94' is a magic number. | 186 | |
| '}' should be alone on a line. | 200 | |
| Cyclomatic Complexity is 12 (max allowed is 10). | 220 | |
| NPath Complexity is 432 (max allowed is 20). | 220 | |
| '}' should be alone on a line. | 229 |
| Violation | Message | Line |
|---|---|---|
| The String "%-10s" appears 2 times in the file. | 31 | |
| '4' is a magic number. | 308 | |
| '4' is a magic number. | 309 | |
| '20' is a magic number. | 309 | |
| '20' is a magic number. | 310 | |
| '40' is a magic number. | 310 | |
| '40' is a magic number. | 311 | |
| '50' is a magic number. | 311 | |
| '50' is a magic number. | 312 | |
| '53' is a magic number. | 312 | |
| '53' is a magic number. | 313 | |
| '63' is a magic number. | 313 | |
| '63' is a magic number. | 314 | |
| '69' is a magic number. | 314 | |
| '}' should be alone on a line. | 319 | |
| '}' should be alone on a line. | 326 | |
| '78' is a magic number. | 333 | |
| '79' is a magic number. | 334 | |
| '87' is a magic number. | 334 | |
| '87' is a magic number. | 335 | |
| '94' is a magic number. | 335 | |
| NPath Complexity is 256 (max allowed is 20). | 371 |
| Violation | Message | Line |
|---|---|---|
| Class should define a constructor. | 11 |
| Violation | Message | Line |
|---|---|---|
| The String "%06d" appears 2 times in the file. | 16 | |
| The String "%012d" appears 2 times in the file. | 16 | |
| '}' should be alone on a line. | 69 | |
| '}' should be alone on a line. | 95 | |
| '7' is a magic number. | 131 | |
| '7' is a magic number. | 132 | |
| '13' is a magic number. | 132 | |
| '13' is a magic number. | 133 | |
| '21' is a magic number. | 133 | |
| '21' is a magic number. | 134 | |
| '31' is a magic number. | 134 | |
| '31' is a magic number. | 135 | |
| '43' is a magic number. | 135 | |
| '43' is a magic number. | 136 | |
| '55' is a magic number. | 136 | |
| '}' should be alone on a line. | 151 |
| Violation | Message | Line |
|---|---|---|
| The String "%02d" appears 2 times in the file. | 22 | |
| The String " %08d%01d" appears 2 times in the file. | 22 | |
| The String "%c" appears 2 times in the file. | 22 | |
| The String "%-23s" appears 2 times in the file. | 23 | |
| '3' is a magic number. | 301 | |
| '3' is a magic number. | 302 | |
| '12' is a magic number. | 302 | |
| '12' is a magic number. | 303 | |
| '13' is a magic number. | 304 | |
| '22' is a magic number. | 304 | |
| '22' is a magic number. | 305 | |
| '23' is a magic number. | 307 | |
| '33' is a magic number. | 307 | |
| '33' is a magic number. | 312 | |
| '34' is a magic number. | 313 | |
| '37' is a magic number. | 313 | |
| '37' is a magic number. | 314 | |
| '39' is a magic number. | 314 | |
| '39' is a magic number. | 315 | |
| '40' is a magic number. | 316 | |
| '63' is a magic number. | 316 | |
| '63' is a magic number. | 317 | |
| '86' is a magic number. | 317 | |
| '86' is a magic number. | 318 | |
| '94' is a magic number. | 318 | |
| NPath Complexity is 64 (max allowed is 20). | 325 | |
| '}' should be alone on a line. | 332 | |
| NPath Complexity is 128 (max allowed is 20). | 394 |
| Violation | Message | Line |
|---|---|---|
| '}' should be alone on a line. | 68 | |
| '}' should be alone on a line. | 89 |
| Violation | Message | Line |
|---|---|---|
| Anonymous inner class length is 33 lines (max allowed is 20). | 15 |
| Violation | Message | Line |
|---|---|---|
| '}' should be alone on a line. | 32 | |
| Constructor definition in wrong order. | 48 | |
| Constructor definition in wrong order. | 56 | |
| Constructor definition in wrong order. | 66 | |
| Expected @param tag for 'check'. | 66 | |
| '}' should be alone on a line. | 117 | |
| '}' should be alone on a line. | 119 |
| Violation | Message | Line |
|---|---|---|
| '}' should be alone on a line. | 38 | |
| '9' is a magic number. | 38 | |
| '}' should be alone on a line. | 40 | |
| '8' is a magic number. | 41 | |
| '8' is a magic number. | 41 | |
| '9' is a magic number. | 44 |
| Violation | Message | Line |
|---|---|---|
| Name 'X_ACH_XL' must match pattern '^[A-Z][a-zA-Z0-9]*$'. | 22 | |
| '}' should be alone on a line. | 78 | |
| '}' should be alone on a line. | 83 | |
| Cyclomatic Complexity is 17 (max allowed is 10). | 102 | |
| NCSS for this method is 52 (max allowed is 50). | 102 |
| Violation | Message | Line |
|---|---|---|
| Name 'X_ACH_XP' must match pattern '^[A-Z][a-zA-Z0-9]*$'. | 17 | |
| array initialization child at indentation level 12 not at correct indentation, [8, 66] | 30 | |
| array initialization child at indentation level 12 not at correct indentation, [8, 66] | 31 | |
| array initialization child at indentation level 12 not at correct indentation, [8, 66] | 32 | |
| array initialization child at indentation level 12 not at correct indentation, [8, 66] | 33 | |
| array initialization child at indentation level 12 not at correct indentation, [8, 66] | 34 | |
| array initialization child at indentation level 12 not at correct indentation, [8, 66] | 35 | |
| Array should contain trailing comma. | 36 | |
| array initialization child at indentation level 12 not at correct indentation, [8, 66] | 36 | |
| array initialization child at indentation level 12 not at correct indentation, [8, 64] | 43 | |
| array initialization child at indentation level 12 not at correct indentation, [8, 64] | 44 | |
| array initialization child at indentation level 12 not at correct indentation, [8, 64] | 45 | |
| array initialization child at indentation level 12 not at correct indentation, [8, 64] | 46 | |
| array initialization child at indentation level 12 not at correct indentation, [8, 64] | 47 | |
| Array should contain trailing comma. | 48 | |
| array initialization child at indentation level 12 not at correct indentation, [8, 64] | 48 | |
| '127' is a magic number. | 85 | |
| '256' is a magic number. | 85 | |
| '128' is a magic number. | 86 | |
| '}' should be alone on a line. | 87 | |
| '256' is a magic number. | 87 | |
| '384' is a magic number. | 87 | |
| '256' is a magic number. | 88 | |
| '}' should be alone on a line. | 89 | |
| '}' should be alone on a line. | 95 |
| Violation | Message | Line |
|---|---|---|
| Name 'X_US_ASCII_ACH' must match pattern '^[A-Z][a-zA-Z0-9]*$'. | 23 | |
| Return count is 4 (max allowed is 2). | 54 | |
| '32' is a magic number. | 59 | |
| Return count is 5 (max allowed is 2). | 105 | |
| '32' is a magic number. | 115 | |
| '127' is a magic number. | 115 | |
| '}' should be alone on a line. | 120 |
| Violation | Message | Line |
|---|---|---|
| Wrong order for 'net.sf.bacchus.InvalidRecordException' import. | 8 | |
| '3' is a magic number. | 104 |
| Violation | Message | Line |
|---|---|---|
| Wrong order for 'net.sf.bacchus.InvalidRecordException' import. | 15 | |
| The String "%01d" appears 3 times in the file. | 39 | |
| '}' should be alone on a line. | 239 | |
| '3' is a magic number. | 304 | |
| '3' is a magic number. | 305 | |
| '11' is a magic number. | 305 | |
| '11' is a magic number. | 306 | |
| '12' is a magic number. | 307 | |
| '29' is a magic number. | 307 | |
| '29' is a magic number. | 308 | |
| '39' is a magic number. | 308 | |
| '76' is a magic number. | 309 | |
| '78' is a magic number. | 309 | |
| '78' is a magic number. | 310 | |
| '79' is a magic number. | 311 | |
| '94' is a magic number. | 311 | |
| '}' should be alone on a line. | 312 | |
| Cyclomatic Complexity is 14 (max allowed is 10). | 321 | |
| NPath Complexity is 576 (max allowed is 20). | 321 | |
| '}' should be alone on a line. | 329 | |
| '}' should be alone on a line. | 331 | |
| '}' should be alone on a line. | 343 | |
| Cyclomatic Complexity is 13 (max allowed is 10). | 392 | |
| NPath Complexity is 640 (max allowed is 20). | 392 |
| Violation | Message | Line |
|---|---|---|
| Class should define a constructor. | 14 | |
| '}' should be alone on a line. | 49 |
| Violation | Message | Line |
|---|---|---|
| Wrong order for 'net.sf.bacchus.InvalidRecordException' import. | 9 | |
| Class should define a constructor. | 12 | |
| Class should define a constructor. | 18 | |
| '}' should be alone on a line. | 99 | |
| '39' is a magic number. | 111 | |
| '61' is a magic number. | 111 | |
| '61' is a magic number. | 112 | |
| '76' is a magic number. | 112 | |
| '76' is a magic number. | 113 | |
| '78' is a magic number. | 113 | |
| '39' is a magic number. | 160 | |
| '78' is a magic number. | 160 |
| Violation | Message | Line |
|---|---|---|
| Class should define a constructor. | 8 | |
| '39' is a magic number. | 58 | |
| '54' is a magic number. | 58 | |
| '54' is a magic number. | 59 | |
| '76' is a magic number. | 59 | |
| '39' is a magic number. | 88 | |
| '76' is a magic number. | 88 |
| Violation | Message | Line |
|---|---|---|
| Class should define a constructor. | 8 | |
| The String "%-11s" appears 2 times in the file. | 11 | |
| '39' is a magic number. | 78 | |
| '53' is a magic number. | 78 | |
| '53' is a magic number. | 79 | |
| '64' is a magic number. | 79 | |
| '64' is a magic number. | 80 | |
| '75' is a magic number. | 80 | |
| '39' is a magic number. | 114 | |
| '76' is a magic number. | 114 |
| Violation | Message | Line |
|---|---|---|
| Class should define a constructor. | 8 | |
| Variable access definition in wrong order. | 17 | |
| '3' is a magic number. | 65 | |
| '83' is a magic number. | 65 | |
| '83' is a magic number. | 66 | |
| '87' is a magic number. | 66 | |
| '87' is a magic number. | 67 | |
| '94' is a magic number. | 67 |
| Violation | Message | Line |
|---|---|---|
| Class should define a constructor. | 8 | |
| '39' is a magic number. | 58 | |
| '53' is a magic number. | 58 | |
| '53' is a magic number. | 59 | |
| '75' is a magic number. | 59 | |
| '39' is a magic number. | 89 | |
| '76' is a magic number. | 89 |
| Violation | Message | Line |
|---|---|---|
| Class should define a constructor. | 8 | |
| '39' is a magic number. | 58 | |
| '48' is a magic number. | 58 | |
| '48' is a magic number. | 59 | |
| '52' is a magic number. | 59 | |
| '52' is a magic number. | 60 | |
| '54' is a magic number. | 60 | |
| '48' is a magic number. | 88 | |
| '54' is a magic number. | 88 |
| Violation | Message | Line |
|---|---|---|
| Missing a Javadoc comment. | 3 | |
| Class should define a constructor. | 3 |
| Violation | Message | Line |
|---|---|---|
| The String "%-6s" appears 3 times in the file. | 24 | |
| The String "%-15s" appears 2 times in the file. | 24 | |
| Boolean expression complexity is 5 (max allowed is 3). | 75 | |
| '13' is a magic number. | 217 | |
| '19' is a magic number. | 217 | |
| '19' is a magic number. | 218 | |
| '25' is a magic number. | 218 | |
| '}' should be alone on a line. | 223 | |
| '29' is a magic number. | 230 | |
| '35' is a magic number. | 230 | |
| '35' is a magic number. | 231 | |
| '62' is a magic number. | 231 | |
| '62' is a magic number. | 232 | |
| '77' is a magic number. | 232 | |
| '77' is a magic number. | 233 | |
| '79' is a magic number. | 233 | |
| '79' is a magic number. | 234 | |
| '94' is a magic number. | 234 | |
| NPath Complexity is 64 (max allowed is 20). | 254 |
| Violation | Message | Line |
|---|---|---|
| Class should define a constructor. | 4 |
| Violation | Message | Line |
|---|---|---|
| Class should define a constructor. | 11 |
| Violation | Message | Line |
|---|---|---|
| Wrong order for 'org.springframework.batch.item.file.transform.LineAggregator' import. | 5 | |
| Class should define a constructor. | 12 |
| Violation | Message | Line |
|---|---|---|
| Wrong order for 'org.springframework.batch.item.ItemProcessor' import. | 5 | |
| Class should define a constructor. | 11 |
| Violation | Message | Line |
|---|---|---|
| 'net.sf.bacchus.Record' should be separated from previous imports. | 6 | |
| Class should define a constructor. | 12 |
| Violation | Message | Line |
|---|---|---|
| Wrong order for 'org.springframework.batch.item.ItemProcessor' import. | 15 | |
| Class should define a constructor. | 29 | |
| Line is longer than 120 characters. | 32 | |
| Variable 'allowUnrecognized' explicitly initialized to 'false' (default value for its type). | 38 | |
| Unused @throws tag for 'NullPointerException'. | 71 | |
| Cyclomatic Complexity is 11 (max allowed is 10). | 74 | |
| '}' should be alone on a line. | 79 | |
| '}' should be alone on a line. | 82 | |
| '}' should be alone on a line. | 102 | |
| '}' should be alone on a line. | 109 |
| Violation | Message | Line |
|---|---|---|
| Unused import - java.io.BufferedReader. | 3 | |
| Wrong order for 'org.springframework.batch.item.ReaderNotOpenException' import. | 17 | |
| '10' is a magic number. | 33 | |
| 'lenient' hides a field. | 85 | |
| '}' should be alone on a line. | 101 | |
| Expected an @return tag. | 123 | |
| '}' should be alone on a line. | 133 | |
| Expected @throws tag for 'IOException'. | 146 | |
| '}' should be alone on a line. | 151 | |
| '}' should be alone on a line. | 153 | |
| Instantiation of java.lang.String should be avoided. | 155 | |
| '}' should be alone on a line. | 162 | |
| Expected an @return tag. | 181 | |
| '}' should be alone on a line. | 185 |
| Violation | Message | Line |
|---|---|---|
| Wrong order for 'org.springframework.batch.item.ExecutionContext' import. | 21 | |
| Class Data Abstraction Coupling is 13 (max allowed is 10) classes [Check, CompanyBatchControl, CompanyBatchHeader, DestroyedCheck, FileControl, FileHeader, Info, InvalidRecordException, Payment, PointOfPurchase, Terminal, TruncatedCheck, WebPayment]. | 28 | |
| Class should define a constructor. | 28 | |
| '}' should be alone on a line. | 99 | |
| '}' should be alone on a line. | 119 | |
| '}' should be alone on a line. | 124 | |
| '}' should be alone on a line. | 126 | |
| Cyclomatic Complexity is 17 (max allowed is 10). | 139 | |
| Return count is 4 (max allowed is 2). | 139 | |
| Expected @throws tag for 'InvalidRecordException'. | 140 | |
| '}' should be alone on a line. | 143 | |
| '}' should be alone on a line. | 146 | |
| '}' should be alone on a line. | 149 | |
| '}' should be alone on a line. | 179 | |
| Return count is 3 (max allowed is 2). | 195 | |
| '}' should be alone on a line. | 199 | |
| '}' should be alone on a line. | 228 | |
| '}' should be alone on a line. | 244 |
| Violation | Message | Line |
|---|---|---|
| Wrong order for 'net.sf.bacchus.InvalidRecordException' import. | 4 | |
| Wrong order for 'org.springframework.batch.item.validator.ValidationException' import. | 6 | |
| Class should define a constructor. | 13 | |
| Unused @throws tag for 'NullPointerException'. | 17 | |
| Expected @param tag for 'value'. | 21 | |
| '}' should be alone on a line. | 24 |